Phase 3 Cleanup: Complete Ads-Channel Decoupling

Summary

Fixed the remaining TypeScript compilation errors from Phase 3 (Ads-Channel split) by removing all references to channelId and channel relationship from the Ads model throughout the codebase.

Changes Made

1. ads.service.ts (box-mgnt-api)

File: apps/box-mgnt-api/src/mgnt-backend/feature/ads/ads.service.ts

Removed channelId field from create/update data and removed channel from include statements in:

create() method - removed channelId: dto.channelId from data, removed channel: true from include
update() method - removed channelId: dto.channelId from data, removed channel: true from include
findOne() method - removed channel: true from include
list() method - removed where.channelId = dto.channelId filter, removed channel: true from include
uploadCoverImage() method - removed channel: true from include

Note: The assertChannelExists() validation call was retained because it validates that the channel exists (used for business rules), but the Ad itself no longer stores the channelId.

2. ad-pool.service.ts (libs/core)

File: libs/core/src/ad/ad-pool.service.ts

Updated AdPayload interface and removed channel references:

Removed channelId: string field from AdPayload interface
Removed channelName?: string field from AdPayload interface
Updated rebuildPoolForType() method - removed channel: { select: { name: true } } from include, removed channelId and channelName from payload mapping
Updated getRandomFromDb() method - removed channel: { select: { name: true } } from include, removed channelId and channelName from payload

3. ad-cache-warmup.service.ts (libs/core)

File: libs/core/src/ad/ad-cache-warmup.service.ts

Updated CachedAd interface and removed channel references:

Removed channelId: string field from CachedAd interface
Updated onModuleInit() warmup method - removed channelId: ad.channelId from cached ad object
Updated warmupSingleAd() method - removed channelId: ad.channelId from cached ad object

4. recommendation.service.ts (box-app-api)

File: apps/box-app-api/src/feature/recommendation/recommendation.service.ts

Removed channel-based filtering:

Removed channelId filter from eligibleAds query where clause in the recommendation algorithm

Files Modified

✅ apps/box-mgnt-api/src/mgnt-backend/feature/ads/ads.service.ts
✅ libs/core/src/ad/ad-pool.service.ts
✅ libs/core/src/ad/ad-cache-warmup.service.ts
✅ apps/box-app-api/src/feature/recommendation/recommendation.service.ts

Compilation Result

✅ All TypeScript errors resolved

Before: 18 compilation errors
After: 0 compilation errors

Impact Analysis

Before This Cleanup

// ❌ This was failing
const ad = await prisma.ads.create({
  data: {
    channelId: dto.channelId, // ❌ Error: field doesn't exist
    adsModuleId: dto.adsModuleId,
  },
  include: { channel: true }, // ❌ Error: relation doesn't exist
});

After This Cleanup

// ✅ This now works
const ad = await prisma.ads.create({
  data: {
    adsModuleId: dto.adsModuleId,
    // channelId removed - Ads is now independent
  },
  include: { adsModule: true },
});

Architecture Note

Ads Relationships After Cleanup:

Before (Phase 2):
  Channel (1) ──── (Many) Ads ──── (Many) AdsModule

After Phase 3 (Current):
  Ads ──── (Many) AdsModule

  Channel ──── (Many) Category
          ──── (Many) Tag

Ads are now completely decoupled from channels. The channelId parameter in DTOs and service calls is still accepted and used for business validation (to ensure the channel exists), but the Ad record itself does not store or reference the channel.

Data Flow Impact

Ad Creation: Still validates channel exists but doesn't store channelId
Ad Caching: No longer includes channel name in cached ad payload
Recommendations: Generates recommendations across all ads regardless of channel (more diverse recommendations possible)

Testing Recommendations

Verify ads can be created without channel-specific constraints
Confirm ad pool caching works without channel information
Test recommendation engine with cross-channel ad suggestions
Validate that ad filtering by module still works correctly

Phase 3 Cleanup Status: ✅ COMPLETE Date Completed: 2025-12-09 Files Fixed: 4 Compilation Errors Before: 18 Compilation Errors After: 0

PHASE3_CLEANUP_SUMMARY.md 4.5 KB 文件歷史 原始文件